Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Windows Release with CMake (part1) #61225

Merged
merged 10 commits into from
Oct 20, 2022
Merged

Build Windows Release with CMake (part1) #61225

merged 10 commits into from
Oct 20, 2022

Conversation

alef
Copy link
Contributor

@alef alef commented Sep 24, 2022

Summary

None

Purpose of change

Try to align CMake build to match the release.

Describe the solution

  • Deal with some package name differing between VCPKG and other distributions
  • Use the proper way for supporting ccache
  • Add missing files to the relase

Describe alternatives you've considered

Testing

  1. Drafting this PR
  2. Watch CI build
  3. Undraft if no side-effects

Additional context

Part of discarded #60159

@github-actions github-actions bot added Code: Build Issues regarding different builds and build environments Translation I18n json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 24, 2022
@alef alef marked this pull request as ready for review September 24, 2022 16:59
@BrettDong
Copy link
Member

I tried your branch and I can successfully build cataclysm-tiles.exe on Windows with MSVC and CMake. However I found I need to delete findSDL2_ttf.cmake in CMakeModules directory, otherwise there will be a CMake configuration error saying unable to find either target SDL2_ttf::SDL2_ttf or SDL2_ttf::SDL2_ttf-static. I guess the findSDL2_ttf.cmake in CMakeModules is too old that it does not provide a modern CMake style target for the project to consume?

@kevingranade kevingranade merged commit 3c575e5 into CleverRaven:master Oct 20, 2022
@alef alef deleted the cmake-presets-part1 branch October 20, 2022 12:36
@perryprog perryprog mentioned this pull request Nov 15, 2022
Merged
@olanti-p olanti-p mentioned this pull request Oct 17, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrettDong BrettDong Awaiting requested review from BrettDong

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Build Issues regarding different builds and build environments json-styled JSON lint passed, label assigned by github actions Translation I18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alef @BrettDong @kevingranade